Breaking: remove source property from linting messages (fixes #7358)
#10012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-an-aardvark
added
enhancement
platinumazure
approved these changes
Feb 24, 2018
There was a problem hiding this comment.
Maybe this should be addressed in a future PR (especially if the place to do this is the migration guide), but I think it could be useful to add an example of using .slice on the top-level source with the range info provided in the message, to extract the affected source code (for integrations). Otherwise LGTM.
|
I think adding that to the migration guide would be a good idea. |
ilyavolodin
approved these changes
Feb 25, 2018
not-an-aardvark
force-pushed
the
remove-source
branch
from
38fc8e1
to
dd6ca13
Compare
not-an-aardvark
force-pushed
the
remove-source
branch
from
dd6ca13
to
4bacf80
Compare
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This removes the
sourceproperty from individual linting messages, as described in #7358. The property has been deprecated since October 2016.Is there anything you'd like reviewers to focus on?
Nothing in particular