New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: remove `source` property from linting messages (fixes #7358) #10012

Merged
merged 2 commits into from Mar 22, 2018

Conversation

Projects
3 participants
@not-an-aardvark
Member

not-an-aardvark commented Feb 23, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

This removes the source property from individual linting messages, as described in #7358. The property has been deprecated since October 2016.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@platinumazure

Maybe this should be addressed in a future PR (especially if the place to do this is the migration guide), but I think it could be useful to add an example of using .slice on the top-level source with the range info provided in the message, to extract the affected source code (for integrations). Otherwise LGTM.

@not-an-aardvark

This comment has been minimized.

Member

not-an-aardvark commented Feb 24, 2018

I think adding that to the migration guide would be a good idea.

not-an-aardvark added some commits Feb 23, 2018

@not-an-aardvark not-an-aardvark merged commit 27e3f24 into master Mar 22, 2018

5 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

v5.0.0 automation moved this from Ready to merge to Done Mar 22, 2018

@not-an-aardvark not-an-aardvark deleted the remove-source branch Mar 22, 2018

@eslint eslint bot locked and limited conversation to collaborators Sep 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.