Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-invalid-regexp not understand variable for flags (fixes #10112) #10113

Merged
merged 1 commit into from Mar 22, 2018

Conversation

@aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Mar 21, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix (template)

What changes did you make? (Give an overview)
flags was Initialized to "", but sometimes it could be null -- this might cause confusing.

Is there anything you'd like reviewers to focus on?
no. 馃槂

@eslint eslint bot added the triage label Mar 21, 2018
@aladdin-add aladdin-add requested a review from mysticatea Mar 21, 2018
@aladdin-add aladdin-add added bug rule accepted and removed triage labels Mar 21, 2018
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

LGTM, thanks!

Copy link
Member

@platinumazure platinumazure left a comment

LGTM, thanks!

@not-an-aardvark not-an-aardvark merged commit 3ff5d11 into eslint:master Mar 22, 2018
5 checks passed
5 checks passed
commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor This change is semver-patch
Details
This was referenced Mar 22, 2018
@aladdin-add aladdin-add deleted the aladdin-add:issue10112 branch Mar 22, 2018
@eslint eslint bot locked and limited conversation to collaborators Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.