Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix invalid super() calls in tests #11054

Merged
merged 1 commit into from Nov 6, 2018

Conversation

@not-an-aardvark
Copy link
Member

commented Nov 5, 2018

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

Acorn now reports parsing errors for invalid uses of the super keyword, and some tests are failing on master as a result. This commit updates the affected tests as necessary (or removes them if they're no longer applicable).

Is there anything you'd like reviewers to focus on?

Nothing in particular

Chore: fix invalid super() calls in tests
Acorn now reports parsing errors for invalid uses of the `super` keyword, and some tests are failing on master as a result. This commit updates the affected tests as necessary (or removes them if they're no longer applicable).
@mysticatea
Copy link
Member

left a comment

LGTM, thank you!

@not-an-aardvark not-an-aardvark merged commit 0800b20 into master Nov 6, 2018

5 checks passed

commit-message Commit message follows guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@not-an-aardvark not-an-aardvark deleted the fix-super branch Nov 6, 2018

@eslint eslint bot locked and limited conversation to collaborators May 6, 2019

@eslint eslint bot added the archived due to age label May 6, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.