Fix: Allow escaped whitespace in paths for config initialization (fixes #11099) #11101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
[x] Bug fix
Reproduced and fixed issue #11099 with:
ESLint Version: v5.9.0
Node Version: v10.4.1
What changes did you make?
I changed the regex used in splitting the paths, to skip splitting on an escaped space. Then I remove any leftover
\
characters from the split-out patterns using a.map(..)
.Is there anything you'd like reviewers to focus on?
Because I'm using a regex negative lookbehind, it means this config tool could only run in Node with that recent JS feature present (ES2018), which (I think) was Node 10.0+. Not sure how that impacts eslint's Node support.
Also, I was going to modify the tests for config-initializer here, but decided not to, because it's not clear if there's any reasonable way to get an internal path in eslint with a space in it to be able to test against. :/