-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: handle computed properties in camelcase (fixes #11084) #11113
Conversation
Note to merger: This should be merged as an "Update" since this is a bugfix that adds more warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@madbence It seems like there are some merge conflicts. Would you mind fixing those? |
sure! |
3a37a63
to
9232517
Compare
@not-an-aardvark is anything left i could do? 😸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Tell us about your environment
5.9.0
11.0.0
6.4.1
What parser (default, Babel-ESLint, etc.) are you using? default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
Reported
camelcase
error forcategory_id
.What actually happened? Please include the actual, raw output from ESLint.
No errors reported
What changes did you make? (Give an overview)
isInsideObjectPattern
now stops at computed properties (as the computed property can be a simple expression, andnode
cannot be part of anObjectPattern
anymore).Is there anything you'd like reviewers to focus on?
I'd be happy to add more tests if you can think of more edge-cases.