Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Upgrade: firstname.lastname@example.org #11220
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
left a comment
Basic changes LGTM, thanks!
Regarding rule types for internal rules: I think suggestion makes sense for most of them, but I left a suggestion on one that I think should be a problem. Let me know what you think. Thanks!