New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: eslint-plugin-eslint-plugin@2.0.1 #11220

Merged
merged 2 commits into from Jan 4, 2019

Conversation

Projects
None yet
4 participants
@aladdin-add
Copy link
Member

aladdin-add commented Dec 29, 2018

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)
upgrade eslint-plugin-eslint-plugin@2.0.1, it mainly added a new rule: require-meta-type.

Is there anything you'd like reviewers to focus on?
thoughts on the types of internal rules?

@aladdin-add aladdin-add added the upgrade label Dec 29, 2018

@platinumazure
Copy link
Member

platinumazure left a comment

Basic changes LGTM, thanks!

Regarding rule types for internal rules: I think suggestion makes sense for most of them, but I left a suggestion on one that I think should be a problem. Let me know what you think. Thanks!

Show resolved Hide resolved tools/internal-rules/no-invalid-meta.js Outdated
@btmills

btmills approved these changes Jan 4, 2019

Copy link
Member

btmills left a comment

LGTM, thanks!

@btmills

This comment has been minimized.

Copy link
Member

btmills commented Jan 4, 2019

Closing and reopening to see if it'll wake up the CLA checker.

@btmills btmills closed this Jan 4, 2019

@btmills btmills reopened this Jan 4, 2019

@jsf-clabot

This comment has been minimized.

Copy link

jsf-clabot commented Jan 4, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@platinumazure
Copy link
Member

platinumazure left a comment

LGTM, thanks!

Not sure what's wrong with the CLA checker-- are you using a new e-mail address in some of your commits?

@btmills

This comment has been minimized.

Copy link
Member

btmills commented Jan 4, 2019

It looks like the second commit was made from within the GitHub UI, and it formatted the commit's author name differently. Since the email address is identical, we'll consider them to be the same.

@btmills btmills merged commit 166853d into master Jan 4, 2019

4 of 5 checks passed

licence/cla Contributor License Agreement is not signed yet.
Details
commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
release-monitor No patch release is pending
Details

@not-an-aardvark not-an-aardvark deleted the upgrade/eslint-plugin branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment