Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: extends in glob-based config (fixes #8813) #11554

Merged
merged 4 commits into from May 24, 2019

Conversation

Projects
None yet
3 participants
@mysticatea
Copy link
Member

commented Mar 26, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Add something to the core: fixes #8813

What changes did you make? (Give an overview)

This PR adds support for extends and nested overrides in overrides setting.

Both nested overrides settings and the overrides settings in extended configs in a overrides item work similarly. Those settings will be applied only when both glob patterns of the parent overrides and the child overrides were matched.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@mysticatea

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

I'm not sure why "commit-message" check failed 🤔

@platinumazure platinumazure changed the title New: extends in glob-based config (fixes #8813) New: extends in glob-based config (fixes #8813) Mar 27, 2019

@platinumazure platinumazure changed the title New: extends in glob-based config (fixes #8813) New: extends in glob-based config (fixes #8813) Mar 27, 2019

@mysticatea mysticatea force-pushed the overrides-extends branch from 1d3e90d to b493ee1 May 10, 2019

@mysticatea

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

I updated this PR and I believe ready for review.

mysticatea added some commits May 18, 2019

@mysticatea mysticatea changed the title New: extends in glob-based config (fixes #8813) New: extends in glob-based config (fixes #8813) May 18, 2019

@mysticatea
Copy link
Member Author

left a comment

Thank you for your review!

Show resolved Hide resolved conf/config-schema.js
Show resolved Hide resolved tests/lib/shared/config-validator.js
@aladdin-add
Copy link
Member

left a comment

LGTM, thanks!

@platinumazure
Copy link
Member

left a comment

LGTM, thanks! Just left one question.

Show resolved Hide resolved lib/cli-engine/config-array-factory.js
@mysticatea

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

(If I use GitHub review feature to bundle multiple replies, GitHub seems to show those duplicate. 😕 )

@mysticatea mysticatea merged commit 54e6eda into master May 24, 2019

5 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@mysticatea mysticatea deleted the overrides-extends branch May 24, 2019

kaykayehnn added a commit to kaykayehnn/typescript-react-redux-boilerplate that referenced this pull request May 24, 2019

kaykayehnn added a commit to kaykayehnn/typescript-react-redux-boilerplate that referenced this pull request May 27, 2019

kaykayehnn added a commit to kaykayehnn/typescript-react-redux-boilerplate that referenced this pull request May 30, 2019

kaykayehnn added a commit to kaykayehnn/typescript-react-redux-boilerplate that referenced this pull request May 30, 2019

kaykayehnn added a commit to kaykayehnn/typescript-react-redux-boilerplate that referenced this pull request Jun 18, 2019

kaykayehnn added a commit to kaykayehnn/typescript-react-redux-boilerplate that referenced this pull request Jun 22, 2019

kaykayehnn added a commit to kaykayehnn/typescript-react-redux-boilerplate that referenced this pull request Jun 23, 2019

kaykayehnn added a commit to kaykayehnn/typescript-react-redux-boilerplate that referenced this pull request Jun 23, 2019

kaykayehnn added a commit to kaykayehnn/typescript-react-redux-boilerplate that referenced this pull request Jun 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.