Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: add --resolve-plugins-relative-to flag #11696

Merged
merged 2 commits into from May 11, 2019

Conversation

Projects
None yet
3 participants
@not-an-aardvark
Copy link
Member

commented May 10, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Add something to the core

What changes did you make? (Give an overview)

With the 2018-simplified-package-loading RFC implemented, ESLint always resolves plugins relative to the current working directory. The CWD works well for the most common use case, but is inconvenient for certain integrations. This commit proposes adding a CLI flag to specify an alternative place where plugins should be resolved from.

(Implements eslint/rfcs#18)

Is there anything you'd like reviewers to focus on?

Nothing in particular

New: add --resolve-plugins-relative-to flag
With the [2018-simplified-package-loading RFC](https://github.com/eslint/rfcs/blob/8bc0b80e0b3e54d10991a4774c41f7375dfcbbfe/designs/2018-simplified-package-loading/README.md) implemented, ESLint always resolves plugins relative to the current working directory. The CWD works well for the most common use case, but is inconvenient for certain integrations. This commit proposes adding a CLI flag to specify an alternative place where plugins should be resolved from.

(Implements eslint/rfcs#18)
@mysticatea
Copy link
Member

left a comment

LGTM and one non-blocking nitpicking. Thank you!

Show resolved Hide resolved tests/lib/cli-engine/config-array-factory.js Outdated

@not-an-aardvark not-an-aardvark merged commit 21dd211 into master May 11, 2019

5 checks passed

commit-message PR title follows commit message guidelines
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details

@not-an-aardvark not-an-aardvark deleted the plugin-root-path-flag branch May 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.