Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Other, please explain: improve performance.
What changes did you make? (Give an overview)
This PR improves performance by avoiding to load unused rules.
But this PR keeps static linking for bundlers can recognize rules.
lib/util/lazy-loading-rule-map.js
... The map of built-in rules. This map will load each rule at the first access.lib/cli.js
... This file will iterate all rules at the first access ofrulesMeta
.lib/testers/rule-tester.js
... This file no longer iterates all rules.conf/eslint-recommended.js
... This file no longer iterates all rules.Makefile.js
... The test verifies ifconf/eslint-recommended.js
is correct.Impacts:
Especially, it has a lerge impact if it used fewer rules such as
eslint:recommended
.npm run perf:
Is there anything you'd like reviewers to focus on?
Can we go to this direction?