Breaking: drop Node.js 8 support (refs eslint/rfcs#44) #12700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
added
core
because Unicode Property Escapes is supported since Node.js 10.0.0.
is-combining-character.js was auto-generated file, so it was not linted. But the previous commit makes the file is a regular file, so we should lint it.
because memfs may privide file list in different orders.
mysticatea
added a commit
that referenced
this pull request
Dec 22, 2019
kaicataldo
approved these changes
Jan 6, 2020
kaicataldo
pushed a commit
that referenced
this pull request
Jan 17, 2020
* update no-magic-numbers to recognize bigint * update yoda to recognize bigint * add a no-extend-native test * update ci.yml temporary (this PR is blocked by #12700) * add astUtils.isNumericLiteral and use it in some rules * update no-dupe-class-members * update no-magic-number to support bigint in options * update some rules to use getStaticPropertyName * update quote-props * revert no-useless-computed-key change * revert "allowing {type: 'bigint'}" and update no-magic-number * no-magic-number 'ignores' allows negative bigint
btmills
pushed a commit
that referenced
this pull request
Jan 17, 2020
…12677) * Breaking: lint `overrides` files (fixes #10828, refs eslint/rfcs#20) * update docs * sort for tests See also: #12700 (comment)
montmanu
pushed a commit
to montmanu/eslint
that referenced
this pull request
Mar 4, 2020
…slint#12701) * update no-magic-numbers to recognize bigint * update yoda to recognize bigint * add a no-extend-native test * update ci.yml temporary (this PR is blocked by eslint#12700) * add astUtils.isNumericLiteral and use it in some rules * update no-dupe-class-members * update no-magic-number to support bigint in options * update some rules to use getStaticPropertyName * update quote-props * revert no-useless-computed-key change * revert "allowing {type: 'bigint'}" and update no-magic-number * no-magic-number 'ignores' allows negative bigint
montmanu
pushed a commit
to montmanu/eslint
that referenced
this pull request
Mar 4, 2020
…s#20) (eslint#12677) * Breaking: lint `overrides` files (fixes eslint#10828, refs eslint/rfcs#20) * update docs * sort for tests See also: eslint#12700 (comment)
This was referenced Apr 12, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Other, please explain: drop Node.js 8 support
What changes did you make? (Give an overview)
This PR implements RFC44, drop Node.js 8 (and 11) support.
withFileTypesoption offs.readdirSync.isCombiningCharacterfunction because RegExp Unicode Escapes (\p{...}) gets supported.Module.createRequireFromPath.enginesfield ofpackage.json.memfsbecausemetro-memory-fsdoesn't support newfsAPIs.Is there anything you'd like reviewers to focus on?
Nothing in particular.