Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: drop Node.js 8 support (refs eslint/rfcs#44) #12700

Merged
merged 4 commits into from Jan 7, 2020
Merged

Breaking: drop Node.js 8 support (refs eslint/rfcs#44) #12700

merged 4 commits into from Jan 7, 2020

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Dec 22, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Other, please explain: drop Node.js 8 support

What changes did you make? (Give an overview)

This PR implements RFC44, drop Node.js 8 (and 11) support.

  • Update CI.
  • Update documentation.
  • Use withFileTypes option of fs.readdirSync.
  • Update isCombiningCharacter function because RegExp Unicode Escapes (\p{...}) gets supported.
  • Remove the polyfill of Module.createRequireFromPath.
  • Update the engines field of package.json.
  • Switch the in-memory file system for tests to memfs because metro-memory-fs doesn't support new fs APIs.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@mysticatea mysticatea added core accepted breaking do not merge chore labels Dec 22, 2019
@mysticatea mysticatea added this to Implemented, pending review in v7.0.0 Dec 22, 2019
@mysticatea mysticatea added this to Implemented, pending review in RFCs Dec 22, 2019
mysticatea added 3 commits Dec 22, 2019
because Unicode Property Escapes is supported since Node.js 10.0.0.
is-combining-character.js was auto-generated file, so it was not linted.
But the previous commit makes the file is a regular file, so we should
lint it.
because memfs may privide file list in different orders.
Copy link
Member

@kaicataldo kaicataldo left a comment

LGTM, thanks!

tests/lib/cli-engine/cli-engine.js Show resolved Hide resolved
@kaicataldo kaicataldo removed the do not merge label Dec 23, 2019
@mysticatea mysticatea merged commit 2c28fbb into master Jan 7, 2020
12 checks passed
v7.0.0 automation moved this from Implemented, pending review to Done Jan 7, 2020
@mysticatea mysticatea deleted the rfc44 branch Jan 7, 2020
@mysticatea mysticatea moved this from Implemented, pending review to Done in RFCs Jan 7, 2020
mysticatea added a commit that referenced this issue Jan 7, 2020
kaicataldo pushed a commit that referenced this issue Jan 17, 2020
* update no-magic-numbers to recognize bigint

* update yoda to recognize bigint

* add a no-extend-native test

* update ci.yml temporary (this PR is blocked by #12700)

* add astUtils.isNumericLiteral and use it in some rules

* update no-dupe-class-members

* update no-magic-number to support bigint in options

* update some rules to use getStaticPropertyName

* update quote-props

* revert no-useless-computed-key change

* revert "allowing {type: 'bigint'}" and update no-magic-number

* no-magic-number 'ignores' allows negative bigint
btmills pushed a commit that referenced this issue Jan 17, 2020
…12677)

* Breaking: lint `overrides` files (fixes #10828, refs eslint/rfcs#20)

* update docs

* sort for tests

See also: #12700 (comment)
montmanu pushed a commit to montmanu/eslint that referenced this issue Mar 4, 2020
…slint#12701)

* update no-magic-numbers to recognize bigint

* update yoda to recognize bigint

* add a no-extend-native test

* update ci.yml temporary (this PR is blocked by eslint#12700)

* add astUtils.isNumericLiteral and use it in some rules

* update no-dupe-class-members

* update no-magic-number to support bigint in options

* update some rules to use getStaticPropertyName

* update quote-props

* revert no-useless-computed-key change

* revert "allowing {type: 'bigint'}" and update no-magic-number

* no-magic-number 'ignores' allows negative bigint
montmanu pushed a commit to montmanu/eslint that referenced this issue Mar 4, 2020
…s#20) (eslint#12677)

* Breaking: lint `overrides` files (fixes eslint#10828, refs eslint/rfcs#20)

* update docs

* sort for tests

See also: eslint#12700 (comment)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jul 7, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age label Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age breaking chore core
Projects
No open projects
RFCs
  
Done
v7.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants