-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Refactor to use messageId in a number of rules #12715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for doing this!
@kaicataldo @ilyavolodin I don't mind tackling the rest of them (or at least until I've gotten board as well), as it would give me a good excuse to Could be a good bullet point for the v7 release if they all got done in time? |
Great! Let us know if we can help with anything.
I don’t see why not! Any PRs that are merged are always listed in the release notes blog post as well :) |
What is the purpose of this pull request? (put an "X" next to item)
[x] Other: Helping to bring the codebase closer to standardisation.
What changes did you make? (Give an overview)
I went through the rules and added
messages
to a number of older rules.I picked non-deprecated rules, and rules that could be simply changed (i.e. essentially just a prop change in
context.report
).I did as many as I could before getting bored 😅 (there's about 71 more rules to go)
There should be no functionality changes at all from this PR.
No new tests have been added, and no tests have been changed (apart from switching from hardcoded
message
tomessageId
+data
).Whilst I was at it, I did a little bit of reformatting to standardise on the format style I saw in other rules.
Let me know if you want me to split this up into separate PRs because of its size.