Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: espree@7.3.0 (refs #13568) #13609

Merged
merged 3 commits into from Aug 24, 2020
Merged

Upgrade: espree@7.3.0 (refs #13568) #13609

merged 3 commits into from Aug 24, 2020

Conversation

@kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Aug 22, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Dependency upgrade

refs #13568

What changes did you make? (Give an overview)

As discussed, this PR bumps Espree to include the new ES 2021 language features. Since this environment didn't exist before, I don't think there's much danger in merging this early (even if we don't get the requisite rule changes into the release). That being said, it would be great if we could land it all at once!

cc @anikethsaha @mdjermanovic since you two are working on the core updates :)

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@eslint eslint bot added the triage label Aug 22, 2020
@kaicataldo kaicataldo force-pushed the espree7.3.0 branch from 3651e1f to 71cf0c0 Aug 22, 2020
@kaicataldo kaicataldo added upgrade and removed triage labels Aug 22, 2020
@kaicataldo kaicataldo changed the title Espree7.3.0 Upgrade: espree@7.3.0 Aug 22, 2020
@kaicataldo kaicataldo changed the title Upgrade: espree@7.3.0 Upgrade: espree@7.3.0 (refs #13568) Aug 22, 2020
@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Aug 22, 2020

That being said, it would be great if we could land it all at once!

Those are:

lib/shared/types.js Outdated Show resolved Hide resolved
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

Copy link
Member

@anikethsaha anikethsaha left a comment

🎉

@nzakas
nzakas approved these changes Aug 24, 2020
@nzakas nzakas merged commit 091e52a into master Aug 24, 2020
12 checks passed
12 checks passed
Verify Files
Details
Test (ubuntu-latest, 14.x)
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 10.12.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message PR title follows commit message guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@nzakas nzakas deleted the espree7.3.0 branch Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.