Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix leaky anchors in v4 migration page #13635

Merged
merged 1 commit into from Sep 12, 2020
Merged

Conversation

Krinkle
Copy link
Contributor

@Krinkle Krinkle commented Aug 30, 2020

The void-style tags seem to not work as expected. The later migration guides avoid them. This patch updates the v4 guide to also avoid them.

Screenshot in Firefox of v4 migration guide View source warnings
Screenshot Screenshot 2020-08-30 at 20 26 26

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update

@eslint-deprecated eslint-deprecated bot added the triage label Aug 30, 2020
@anikethsaha anikethsaha added documentation and removed triage labels Sep 8, 2020
Copy link
Member

@kaicataldo kaicataldo left a comment

LGTM, thanks!

@kaicataldo kaicataldo merged commit fc5783d into eslint:master Sep 12, 2020
12 checks passed
@Krinkle Krinkle deleted the patch-1 branch Sep 12, 2020
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 18, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age label Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants