Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: check computed keys in no-prototype-builtins (fixes #13088) #13755

Merged
merged 1 commit into from Oct 19, 2020

Conversation

@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 13, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

fixes #13088

What changes did you make? (Give an overview)

Changed no-prototype-builtins rule to check computed property access and report simple cases like foo["hasOwnProperty"]("bar").

Also refactored the test file so that the tests can be checked by eslint-plugin-eslint-plugin rules.

Is there anything you'd like reviewers to focus on?

The removed TODO suggested to just replace all lines with astUtils.getStaticPropertyName(node.callee) but I think it's more correct to explicitly check for MemberExpression. Also, astUtils.skipChainExpression would be anyway needed to get callee.property.loc.

Copy link
Member

@kaicataldo kaicataldo left a comment

LGTM, thanks!

Copy link
Member

@yeonjuan yeonjuan left a comment

LGTM!

@mdjermanovic mdjermanovic merged commit 67c0605 into master Oct 19, 2020
12 checks passed
12 checks passed
Verify Files
Details
Test (ubuntu-latest, 14.x)
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 10.12.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@mdjermanovic mdjermanovic deleted the issue13088 branch Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.