Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix broken links in Node.js API docs #13771

Merged
merged 1 commit into from Oct 22, 2020

Conversation

@laura-barluzzi
Copy link
Contributor

@laura-barluzzi laura-barluzzi commented Oct 19, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

I was reading the Node.js API page to learn about the CLIEngine deprecation and I noticed that most of the links in the table of contents don't work in the website. This PR only lowercase the link references to fix those links in the website.

This said, I'm aware that currently there is the opened PR #13415 but I notice that there wasn't any activity for over 3 months. Since I found this issue and probably other people will stumble on it, I thought to go ahead and open this PR with a smaller scope to speed the push of the fix.

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Oct 19, 2020
@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 20, 2020

Thanks for fixing this!

Copy link
Member

@mdjermanovic mdjermanovic left a comment

All changes LGTM, thanks!

@nzakas
nzakas approved these changes Oct 22, 2020
Copy link
Member

@nzakas nzakas left a comment

LGTM. Thanks.

@nzakas nzakas merged commit 1457509 into eslint:master Oct 22, 2020
12 checks passed
12 checks passed
Verify Files
Details
Test (ubuntu-latest, 14.x)
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 10.12.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.