Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix broken links in Node.js API docs toc

Merged
merged 2 commits into from Apr 8, 2021
Merged

Docs: fix broken links in Node.js API docs toc #14296

merged 2 commits into from Apr 8, 2021

Conversation

u-sho
Copy link
Contributor

@u-sho u-sho commented Apr 5, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

I was reading the Node.js API page and I noticed that the links in the table of contents don't work in the website. This PR only remove hyphen from the link references to fix those links in the website.

I'm aware that currently there is the opened PR #13415 but I notice that there wasn't any activity for about 9 months.
Since I found this issue and probably other people will stumble on it, I thought to go ahead and open this PR with a smaller scope to speed the push of the fix like #13771 (and because of my faltering English, I borrowed comment from the PR)

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the triage label Apr 5, 2021
Copy link
Member

@aladdin-add aladdin-add left a comment

LGTM, thanks!

@aladdin-add aladdin-add added accepted documentation bug and removed triage labels Apr 7, 2021
@aladdin-add aladdin-add requested a review from mdjermanovic Apr 7, 2021
@mdjermanovic
Copy link
Member

mdjermanovic commented Apr 7, 2021

@u-sho thanks for the PR!

Can you please sign our CLA, so we could merge this?

@u-sho
Copy link
Contributor Author

u-sho commented Apr 8, 2021

@mdjermanovic I appreciate your review. I fixed what you commented and signed the
CLA. And I'll never mind that this PR will be merged.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 71a80e3 into eslint:master Apr 8, 2021
13 checks passed
@mdjermanovic
Copy link
Member

mdjermanovic commented Apr 8, 2021

Thanks for contributing!

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Oct 6, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age label Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted archived due to age bug documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants