Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add more examples for no-func-assign (fixes #13705) #13777

Merged
merged 1 commit into from Oct 22, 2020

Conversation

@snitin315
Copy link
Contributor

@snitin315 snitin315 commented Oct 21, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ X ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

fixes #13705

Added more example for no-func-assign

Is there anything you'd like reviewers to focus on?

@eslint eslint bot added the triage label Oct 21, 2020
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Thanks for the PR!

var a = function hello() {
hello = 123;
};
Comment on lines 51 to 54

This comment has been minimized.

@mdjermanovic

mdjermanovic Oct 21, 2020
Member

This should be incorrect code for this rule, as in this demo. We've agreed to document the actual behavior of this rule regarding named function expressions.

This comment has been minimized.

@snitin315

snitin315 Oct 22, 2020
Author Contributor

Updated 👍🏻 , Please take a look.

@snitin315 snitin315 force-pushed the snitin315:docs/no-func-assign branch from a8f4a09 to fd08cda Oct 22, 2020
Copy link
Member

@mdjermanovic mdjermanovic left a comment

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 637f818 into eslint:master Oct 22, 2020
12 checks passed
12 checks passed
Verify Files
Details
Test (ubuntu-latest, 14.x)
Details
Test (ubuntu-latest, 13.x)
Details
Test (ubuntu-latest, 12.x)
Details
Test (ubuntu-latest, 10.x)
Details
Test (ubuntu-latest, 10.12.0)
Details
Test (windows-latest, 12.x)
Details
Test (macOS-latest, 12.x)
Details
Browser Test
Details
commit-message Commit message follows guidelines
Details
licence/cla Contributor License Agreement is signed.
Details
release-monitor No patch release is pending
Details
@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Oct 22, 2020

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.