Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove for deleted npm run profile script #13931

Merged
merged 1 commit into from Dec 18, 2020
Merged

Docs: Remove for deleted npm run profile script #13931

merged 1 commit into from Dec 18, 2020

Conversation

@btmills
Copy link
Member

@btmills btmills commented Dec 16, 2020

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

The npm run profile script was deleted in #11854 after it stopped working when we moved from Browserify to webpack. This commit removes the leftover docs and two of the three benchmark files. large.js is still used by a test case ensuring we can read > 4k data from stdin.

Is there anything you'd like reviewers to focus on?

I felt safe deleting the previous benchmark examples because if we eventually add in a new profile command, we'll likely want new examples anyway that contain more modern JS rather than just the ES5 examples we had before.

The script was deleted in #11854
after it stopped working when we moved from Browserify to webpack. This
commit removes the leftover docs and two of the three benchmark files.
`large.js` is used by a test case ensuring we can read > 4k data from
stdin. If we eventually add in a new profile command, we'll likely want
new examples anyway that contain more modern JS rather than just the ES5
examples we had before.
@mdjermanovic
Copy link
Member

@mdjermanovic mdjermanovic commented Dec 18, 2020

I felt safe deleting the previous benchmark examples because if we eventually add in a new profile command, we'll likely want new examples anyway that contain more modern JS rather than just the ES5 examples we had before.

Makes sense to me! And makes sense to remove docs for a script that doesn't exist at the moment, until we add it again.

Loading

@btmills btmills merged commit 9247683 into master Dec 18, 2020
13 checks passed
Loading
@btmills btmills deleted the profile-docs branch Dec 18, 2020
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants