Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: migrate rbTree to js-sdsl #16267

Merged
merged 3 commits into from Sep 12, 2022
Merged

Conversation

ZLY201
Copy link
Contributor

@ZLY201 ZLY201 commented Aug 31, 2022

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: migrate rbTree from functional-red-black-tree to js-sdsl.

What changes did you make? (Give an overview)

Migrate rbTree from functional-red-black-tree to js-sdsl. fixes #16255

Is there anything you'd like reviewers to focus on?

No.

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Aug 31, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 31, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • login: ZLY201 / name: Zilong Yao (8b6d343)

@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Aug 31, 2022
@netlify
Copy link

netlify bot commented Aug 31, 2022

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 42b8a9c
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/631853b2ed3c88000814a4ee
😎 Deploy Preview https://deploy-preview-16267--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ZLY201 ZLY201 force-pushed the perf/migrate-rbtree branch 3 times, most recently from 946f3d8 to 57b6d72 Compare Aug 31, 2022
lib/rules/indent.js Show resolved Hide resolved
lib/rules/indent.js Outdated Show resolved Hide resolved
lib/rules/indent.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ZLY201
Copy link
Contributor Author

ZLY201 commented Sep 1, 2022

I think this PR should linked to this issue?

Copy link
Member

@aladdin-add aladdin-add left a comment

LGTM, thanks! 💯

@aladdin-add aladdin-add requested review from mdjermanovic and nzakas Sep 2, 2022
package.json Outdated Show resolved Hide resolved
nzakas
nzakas approved these changes Sep 8, 2022
Copy link
Member

@nzakas nzakas left a comment

Changes look good. Do we have any before and after perf numbers?

@aladdin-add
Copy link
Member

aladdin-add commented Sep 8, 2022

@nzakas , the perf result was posted in here: #16255 (comment)

Copy link
Member

@btmills btmills left a comment

Shaving a second off of the indent rule in your benchmark is a great improvement - thanks!

@btmills btmills merged commit 38e8171 into eslint:main Sep 12, 2022
20 checks passed
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Sep 22, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | patch | [`8.23.0` -> `8.23.1`](https://renovatebot.com/diffs/npm/eslint/8.23.0/8.23.1) |

---

### Release Notes

<details>
<summary>eslint/eslint</summary>

### [`v8.23.1`](https://github.com/eslint/eslint/releases/tag/v8.23.1)

[Compare Source](eslint/eslint@v8.23.0...v8.23.1)

#### Bug Fixes

-   [`b719893`](eslint/eslint@b719893) fix: Upgrade eslintrc to stop redefining plugins ([#&#8203;16297](eslint/eslint#16297)) (Brandon Mills)
-   [`734b54e`](eslint/eslint@734b54e) fix: improve autofix for the `prefer-const` rule ([#&#8203;16292](eslint/eslint#16292)) (Nitin Kumar)
-   [`6a923ff`](eslint/eslint@6a923ff) fix: Ensure that glob patterns are normalized ([#&#8203;16287](eslint/eslint#16287)) (Nicholas C. Zakas)
-   [`c6900f8`](eslint/eslint@c6900f8) fix: Ensure globbing doesn't include subdirectories ([#&#8203;16272](eslint/eslint#16272)) (Nicholas C. Zakas)

#### Documentation

-   [`16cba3f`](eslint/eslint@16cba3f) docs: fix mobile double tap issue ([#&#8203;16293](eslint/eslint#16293)) (Sam Chen)
-   [`e098b5f`](eslint/eslint@e098b5f) docs: keyboard control to search results ([#&#8203;16222](eslint/eslint#16222)) (Shanmughapriyan S)
-   [`1b5b2a7`](eslint/eslint@1b5b2a7) docs: add Consolas font and prioritize resource loading ([#&#8203;16225](eslint/eslint#16225)) (Amaresh  S M)
-   [`1ae8236`](eslint/eslint@1ae8236) docs: copy & use main package version in docs on release ([#&#8203;16252](eslint/eslint#16252)) (Jugal Thakkar)
-   [`279f0af`](eslint/eslint@279f0af) docs: Improve id-denylist documentation ([#&#8203;16223](eslint/eslint#16223)) (Mert Ciflikli)

#### Chores

-   [`38e8171`](eslint/eslint@38e8171) perf: migrate rbTree to js-sdsl ([#&#8203;16267](eslint/eslint#16267)) (Zilong Yao)
-   [`1c388fb`](eslint/eslint@1c388fb) chore: switch nyc to c8 ([#&#8203;16263](eslint/eslint#16263)) (唯然)
-   [`67db10c`](eslint/eslint@67db10c) chore: enable linting `.eleventy.js` again ([#&#8203;16274](eslint/eslint#16274)) (Milos Djermanovic)
-   [`42bfbd7`](eslint/eslint@42bfbd7) chore: fix `npm run perf` crashes ([#&#8203;16258](eslint/eslint#16258)) (唯然)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTQuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5NC41In0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1543
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This change is not user-facing contributor pool triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate functional-red-black-tree to Js-sdsl OrderedMap
5 participants