fix: use-isnan doesn't report on SequenceExpressions
#18059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@StyleShit can you please update your description and fill out the pull request template? This is required in every PR. Thanks! |
|
@nzakas Sure, sorry for that (again... 😅) I'm just used to opening a PR from my local machine without even opening Github, so it doesn't add the template. |
|
That's what I figured, no worries. :) |
nzakas
added
the
accepted
nzakas
requested changes
Jan 31, 2024
|
That's a good idea! |
amareshsm
added
rule
mdjermanovic
reviewed
Feb 1, 2024
mdjermanovic
reviewed
Feb 3, 2024
mdjermanovic
approved these changes
Feb 5, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
The
use-isnanrule didn't reportSequenceExpressions, so I've added a short condition to check for that, plus some testsCloses #18058