feat: add suggestions to use-isnan in indexOf & lastIndexOf calls
#18063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amareshsm
reviewed
Feb 1, 2024
|
Marking as a draft so we don't accidentally merge. |
|
I don't think it's worth the extra effort to give more than one suggestion for this. |
|
@nzakas Ready for review 😄 |
nzakas
requested changes
Feb 9, 2024
lib/rules/use-isnan.js
Outdated
| * To retain side effects, it's essential to address `NaN` beforehand, which | ||
| * is not possible with fixes like `arr.findIndex(Number.isNaN)`. | ||
| */ | ||
| const isFixable = node.arguments[0].type !== "SequenceExpression"; |
There was a problem hiding this comment.
I think isFixable actually means isSuggestable? (To disambiguate between fixes and suggestions, it's probably better to keep the naming in line.)
There was a problem hiding this comment.
ugh... I always mix them up...
fixed (pun intended 😄)
nzakas
added
accepted
mdjermanovic
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
This PR adds suggestions to
use-isnanwhen usingindexOfandlastIndexOf.The current fix changes them to
findIndex&findLastIndexrespectively.I wanted to suggest also
includesandsomeas second and third suggestions, but I got into a rabbit hole of checking whether the parent node is aBinaryExpressionand whether the developer usedindexOf() !== -1,indexOf() > 0, etc.We can probably do that, just need to find all the cases. Do you think it's worth the effort?
(Probably?) Closes #17978
NOTE
Let's wait until #18059 is merged before merging this one, because it'll require me to extend the new tests that were added there.