Fix: Ensure piped in code will trigger correct errors (fixes #2154) #2162
Conversation
| } catch (ex) { | ||
| console.error(ex.message); | ||
| exitCode = 1; | ||
| } |
There was a problem hiding this comment.
Wouldn’t this error also end up in the error event of the stream? Anyway it is always a good idea to add an error handler to every error event (https://github.com/maxogden/concat-stream#error-handling).
There was a problem hiding this comment.
No, the error is thrown in the callback, not in the process of reading the stream.
There was a problem hiding this comment.
Interesting, but somewhere the error gets caught.
There was a problem hiding this comment.
Yup, I just have no idea where and not enough patience to keep digging in. :)
|
Maybe we should try to extract this functionality to a different file where we can write tests more easily or we should write tests for |
|
If you want to take a stab at writing tests, I'm all for it. I just don't have the time to figure out the best way to do it (this is part of why we have |
Fix: Ensure piped in code will trigger correct errors (fixes #2154)
|
Alright, I will investigate how we could test this. |
eslint-deprecated
bot
added
the
archived due to age
This is a bit gross.
bin/eslint.jsis the one file we don't have unit tests for, but I verified this is working.The error was being swallowed because the method was being called in a callback.