Update: add allowParens option to no-confusing-arrow
#5500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @michaelficarra, @lukekarrys and @jrvidal to be potential reviewers |
|
LGTM |
| 1. `true` relaxes the rule and accepts parenthesis as a valid "confusion-preventing" syntax. | ||
| 2. `false` warns even if the expression is wrapped in parenthesis | ||
|
|
||
| When `allowParens` is set to `true` following patterns are no longer considered as warnings: |
There was a problem hiding this comment.
Can you reformat this to follow the example set by @pedrottimark in #5454?
There was a problem hiding this comment.
Shouldn't we separate two things? Looks like @pedrottimark haven't yet come to no-confusing-arrow so I'm not breaking anything. I'd prefer we continue changing these through his patches and keep this one specific to the problem at hand.
ilyavolodin
added a commit
that referenced
this pull request
Mar 10, 2016
Update: add `allowParens` option to `no-confusing-arrow`
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5332