Fix: overindent in VariableDeclarator parens or brackets (fixes #5492)

[dgreensp]

No description provided.

[eslintbot]

Thanks for the pull request, @dgreensp! I took a look to make sure it's ready for merging and found some changes are needed:

• The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.
• Please sign our CLA. This is just a way for you to say that you give us permission to use your contribution.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

[gyandeeps]

LGTM. Thanks for the PR.

[gyandeeps]

ping @BYK

[BYK]

I feel like someone else's gonna complain about this change so not sure if this should be behind an option (no idea what that will be). Also commit log needs to be fixed, see @eslintbot please @dgreensp :)

[dgreensp]

@BYK I don't think there's anything controversial here. All the existing tests pass except one -- so people still get their hanging braces, etc. etc. -- and this one test was added by you, I think, while fixing #3329, but the original user report actually expects a single indent here, not a double indent, so the test isn't evidence of some other opinion or intention. Anyway, it's hard to imagine an editor or IDE putting a double or triple indent after a trailing bracket.

I think I fixed the bot errors; let me know if not!

[BYK]

Meh, I'm indifferent since I find this exception case weird anyways. I was simply warning you that this would probably break someone else's preference.

If @gyandeeps is okay, the code looks good.

[gyandeeps]

@dgreensp Have signed our CLA?

[ilyavolodin]

Yes, verified CLA. Good to merge?

[gyandeeps]

thanks @ilyavolodin for confirmation .

[dgreensp]

Woot!! Thanks guys!

[ffxsam]

@dgreensp You rock!

[gyandeeps]

Thanks for the PR. 👍