Fix: enable @scope/plugin/ruleId-style specifier (refs #6362)
#6939
Conversation
|
LGTM |
|
@mysticatea, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nzakas, @lo1tuma and @IanVS to be potential reviewers |
| } catch (err) { | ||
| debug("Failed to load plugin eslint-plugin-" + pluginNameWithoutPrefix + ". Proceeding without it."); | ||
| debug("Failed to load plugin " + longName + ". Proceeding without it."); |
There was a problem hiding this comment.
Unrelated to this PR, but I'm not sure "Proceeding without it." makes sense here since we're throwing an exception and killing the CLIEngine process. If you agree, I can make an issue about fixing that debug statement.
There was a problem hiding this comment.
I will fix it additionally in this PR.
Is it OK that I simply remove Proceeding without it.?
There was a problem hiding this comment.
I'm okay with it, but you may want a second opinion. Thanks!
On Aug 19, 2016 9:32 AM, "Toru Nagashima" notifications@github.com wrote:
In lib/config/plugins.js
#6939 (comment):} catch (err) {
debug("Failed to load plugin eslint-plugin-" + pluginNameWithoutPrefix + ". Proceeding without it.");debug("Failed to load plugin " + longName + ". Proceeding without it.");I will fix it additionally in this PR.
Is it OK that I simply remove Proceeding without it.?—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/eslint/eslint/pull/6939/files/fe9d2f7e3dd14558c2df35d55dda4691ded1f888#r75491658,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARWeqzbyDlDnr-QSvxMbISzBGwUW7-Mks5qhb5jgaJpZM4Jogs2
.
|
LGTM |
|
Lgtm, just waiting another day so others can review. |
|
LGTM. @nzakas want to merge? |
eslint-deprecated
bot
added
the
archived due to age
Refs #6362.
This PR just adds the support of
@scope/plugin/rule-style rule specifiers.