Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fixes examples for allowTemplateLiterals #7135

Merged
merged 1 commit into from Sep 13, 2016

Conversation

zoeingram
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ X] Documentation update
[ ] Bug fix ([template](https://github.com/eslint/eslint/blob/master/templates/bug-report.md))
[ ] New rule ([template](https://github.com/eslint/eslint/blob/master/templates/rule-proposal.md))
[ ] Changes an existing rule ([template](https://github.com/eslint/eslint/blob/master/templates/rule-change-proposal.md))
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

If the item you've check above has a template, please paste the template questions here and answer them.

Please check each item to ensure your pull request is ready:

  • [X ] I've read the pull request guide
  • [ X] I've included tests for my change
  • [X ] I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)
In the allowTemplateLiterals section of the quotes rules, the code for "double" demonstrates examples for 'single' documentation, and vice versa. I changed the code in the double and single section to correspond to the appropriate example.

Is there anything you'd like reviewers to focus on?

Corrects 'single' example to correlate to single, and "double" example to correlate to double

Corrects 'single' example to correlate to single, and "double" example to correlate to double
@mention-bot
Copy link

@zoeingram, thanks for your PR! By analyzing the annotation information on this pull request, we identified @scriptdaemon, @IanVS and @mduvall to be potential reviewers

@eslintbot
Copy link

LGTM

@kaicataldo
Copy link
Member

LGTM. Thanks for contributing to ESLint!

@kaicataldo kaicataldo merged commit ac0bb62 into eslint:master Sep 13, 2016
@zoeingram zoeingram deleted the issue7115 branch September 13, 2016 18:52
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants