Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update ecmaVersion instructions #7195

Merged
merged 1 commit into from
Sep 21, 2016
Merged

Docs: Update ecmaVersion instructions #7195

merged 1 commit into from
Sep 21, 2016

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Sep 20, 2016

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Please check each item to ensure your pull request is ready:

  • I've read the pull request guide
  • I've included tests for my change
  • I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)

Added documentation for ECMAScript 8/2017 to the configuring guide. Also added mention of using the 2015, 2016, and 2017 aliases for ecmaVersion.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@nzakas, thanks for your PR! By analyzing the annotation information on this pull request, we identified @btmills, @pedrottimark and @MikeMcl to be potential reviewers

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ilyavolodin ilyavolodin merged commit 0a36138 into master Sep 21, 2016
@nzakas nzakas deleted the es2017 branch September 21, 2016 02:49
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants