refactor: upgrade minimatch version #168
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi there
I noticed that this project uses a really old version of
minimatch
library (v3 where the latest is v10). While it is impossible to upgrade to the latest one (since the author dropped support for Node18, that is listed as a supported engine of this repo), we can still upgrade to the v9 since it supports Node18. The only breaking change I faced is a removal of default export that is easily fixable and all the tests were green again