Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade minimatch version #168

Closed
wants to merge 1 commit into from
Closed

Conversation

vorant94
Copy link

hi there

I noticed that this project uses a really old version of minimatch library (v3 where the latest is v10). While it is impossible to upgrade to the latest one (since the author dropped support for Node18, that is listed as a supported engine of this repo), we can still upgrade to the v9 since it supports Node18. The only breaking change I faced is a removal of default export that is easily fixable and all the tests were green again

@eslint-github-bot
Copy link

Hi @vorant94!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

Copy link

linux-foundation-easycla bot commented Jul 11, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@vorant94 vorant94 changed the title upgrade minimatch version refactor: upgrade minimatch version Jul 11, 2024
@fasttime
Copy link
Member

Hi @vorant94, thanks for the PR, but we can't make this change. As indicated in the README file, this repo only accepts critical bug fixes. The decision to use minimatch in v3 was taken a while ago, you can read more in this discussion.

@fasttime fasttime closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants