Fix: cache compiled config schema #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to check again one part of the change from #5, and it turns out it didn't revert behavior regarding the config schema validation from ESLint v7.7.0.
In particular,
ajv.compileis called every timevalidateConfigSchemais called.In ESLint v7.7.0 the config schema used to be compiled only once and then cached at the module-level. Here's the original source file:
https://github.com/eslint/eslint/blob/v7.7.0/lib/shared/config-validator.js
This PR fixes the code to cache the compiled schema, as it was working in v7.7.0.
This is probably just a minor performance regression, I'm not sure if this needs another patch release for v7.8.0.