Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: remove experimentalObjectRestSpread option #374

Merged
merged 2 commits into from
Mar 30, 2018

Conversation

not-an-aardvark
Copy link
Member

This removes the experimentalObjectRestSpread option from espree, based on the discussion in eslint/eslint#9990 (see eslint/eslint#9990 (comment) for a summary).

Users who want to use object rest/spread should enable ecmaVersion: 2018 instead. As discussed in eslint/eslint#9990, ESLint 5 will translate the experimentalObjectRestSpread option to ecmaVersion: 2018 and emit a deprecation warning.

Users who want to use object rest/spread should enable `ecmaVersion: 2018` instead. As discussed in eslint/eslint#9990, ESLint 5 will translate the `experimentalObjectRestSpread` option to `ecmaVersion: 2018` and emit a deprecation warning.
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any documentation changes needed?

@not-an-aardvark
Copy link
Member Author

Yes, thanks for the reminder. Just updated README.md.

Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@aladdin-add aladdin-add merged commit 6284e09 into master Mar 30, 2018
@aladdin-add aladdin-add deleted the remove-experimental-object-rest-spread branch March 30, 2018 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants