-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VisitorKeys depend on eslint-visitor-keys #389
Conversation
e8e041c
to
bfd0e7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR.
Looks good to me.
But I'm wondering if this change needs a major version bump or not. Though I believe that this change has no impact to ESLint core...
I didn't use VisitorKeys of espree, and I don't think this is widely used by people :) |
I don't think this require a major version change. The output should stay consistent, so an outside consumer should not see any difference (as far as I understand it). |
OK, I will merge this PR as an update. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late to the game, but thanks for doing this!
PR eslint#389 deleted "lib/visitor-keys.js" and replaced all usages with the eslint-visitor-keys package. PR eslint#387 added lib/visitor-keys.js back again for no apparent reason. It looks like eslint#387 has been started before eslint#389, so it needed to integrate those changes and by mistake the file has been added again.
PR #389 deleted "lib/visitor-keys.js" and replaced all usages with the eslint-visitor-keys package. PR #387 added lib/visitor-keys.js back again for no apparent reason. It looks like #387 has been started before #389, so it needed to integrate those changes and by mistake the file has been added again.
This PR is related to #388
Now the VisitorKeys is depend on https://github.com/eslint/eslint-visitor-keys