VisitorKeys depend on eslint-visitor-keys #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othree
force-pushed
the
eslint-visitor-keys
branch
from
e8e041c
to
bfd0e7e
Compare
mysticatea
approved these changes
Oct 7, 2018
|
I didn't use VisitorKeys of espree, and I don't think this is widely used by people :) |
|
I don't think this require a major version change. The output should stay consistent, so an outside consumer should not see any difference (as far as I understand it). |
ilyavolodin
approved these changes
Oct 8, 2018
|
OK, I will merge this PR as an update. Thank you! |
kaicataldo
reviewed
Oct 15, 2018
matz3
added a commit
to matz3/espree
that referenced
this pull request
Jul 9, 2021
PR eslint#389 deleted "lib/visitor-keys.js" and replaced all usages with the eslint-visitor-keys package. PR eslint#387 added lib/visitor-keys.js back again for no apparent reason. It looks like eslint#387 has been started before eslint#389, so it needed to integrate those changes and by mistake the file has been added again.
aladdin-add
pushed a commit
that referenced
this pull request
Jul 9, 2021
PR #389 deleted "lib/visitor-keys.js" and replaced all usages with the eslint-visitor-keys package. PR #387 added lib/visitor-keys.js back again for no apparent reason. It looks like #387 has been started before #389, so it needed to integrate those changes and by mistake the file has been added again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #388
Now the VisitorKeys is depend on https://github.com/eslint/eslint-visitor-keys