Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Implement 'ecmaVersion: latest' (fixes #495) #499

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented May 20, 2021

This is the implementation for #495, which:

  1. Allows ecmaVersion: "latest" as a valid value. Internally, this is just normalized to latestEcmaVersion, as that was the simplest way to validate this value.
  2. Sets the default ecmaVersion to latestEcmaVersion.

tests/lib/options.js Outdated Show resolved Hide resolved
@nzakas nzakas marked this pull request as ready for review May 27, 2021 00:49
lib/options.js Outdated Show resolved Hide resolved
Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>
@nzakas
Copy link
Member Author

nzakas commented Jun 3, 2021

Added the missing test.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nzakas
Copy link
Member Author

nzakas commented Jun 7, 2021

Please see my note on eslint/eslint#14622 (comment) about keeping the default ecmaVersion for Espree at 5.

@nzakas
Copy link
Member Author

nzakas commented Jun 7, 2021

OK, it looks like we are good to move forward with this based on the latest changes to eslint/eslint#14622. 🎉

@nzakas nzakas merged commit b068cea into main Jun 9, 2021
@nzakas nzakas deleted the issue495 branch June 9, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants