Breaking: Implement 'ecmaVersion: latest' (fixes #495) #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyGeoThink2020
approved these changes
May 27, 2021
btmills
reviewed
May 28, 2021
1 task
Co-authored-by: Brandon Mills <btmills@users.noreply.github.com>
btmills
approved these changes
May 29, 2021
|
Added the missing test. |
aladdin-add
approved these changes
Jun 5, 2021
btmills
approved these changes
Jun 6, 2021
|
Please see my note on eslint/eslint#14622 (comment) about keeping the default |
|
OK, it looks like we are good to move forward with this based on the latest changes to eslint/eslint#14622. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation for #495, which:
ecmaVersion: "latest"as a valid value. Internally, this is just normalized tolatestEcmaVersion, as that was the simplest way to validate this value.ecmaVersiontolatestEcmaVersion.