Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Also post releases to Mastodon #152

Merged
merged 2 commits into from Apr 1, 2023
Merged

chore: Also post releases to Mastodon #152

merged 2 commits into from Apr 1, 2023

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Mar 28, 2023

This updates the release process to also post on Mastodon (in addition to Twitter).

mdjermanovic
mdjermanovic reviewed Mar 31, 2023
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in .github/workflows/release-please.yml LGTM.

But you also, accidentally I believe, checked in generator-eslint-2.0.0.tgz file.

@mdjermanovic mdjermanovic mentioned this pull request Mar 31, 2023
Merged
@nzakas
Copy link
Member Author

nzakas commented Mar 31, 2023

Indeed you are correct. Thanks for catching that.

mdjermanovic
mdjermanovic approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit d0f42ab into main Apr 1, 2023
5 checks passed
@mdjermanovic mdjermanovic deleted the mastodon-status branch April 1, 2023 23:33
@github-actions github-actions bot mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmish bmish bmish approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nzakas @bmish @mdjermanovic