New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching problem in tests (same generator and/or same prompts are used in different tests) #44
Comments
Adding single quote pathological tests as well
Background: This is a follow-up issue to #42 (originally solved by #45), where I wanted to make sure that if a user enters certain characters (mostly quotes), that we wouldn't generate a file that was syntactically invalid. I wanted to do so without using XML escapes, which are not what the user would expect. Solving the original issueFor example: if a user enters // ...
ruleTester.run({
// ...
invalid: [
{
code: "var x = "foo";",
errors: "Fill me in"
}
]
} Before #45, we were using The problem I'm now trying to solveWhen I submitted #45, I wanted to add tests for double and single quotes, so we know that the code is behaving correctly. However, I ran into the trouble of Now that I'm using require-uncached, I can add all my single-quote tests back in. So this isn't really solving a new problem, just adding test coverage that I couldn't add originally due to |
Adding single quote pathological tests as well
Extracted from #42. That issue talks about us not escaping double quotes correctly when putting user input in JS code; this one talks about single quotes being replaced by double quotes somewhere in the generator internals.Of course it's a caching problem.
The text was updated successfully, but these errors were encountered: