Breaking: Upgrade yeoman dependencies to latest #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
yeoman-upgrade
branch
10 times, most recently
from
5853fd6
to
e8591e7
Compare
|
Ready for review. |
nzakas
requested changes
Jul 16, 2021
tests/app/index.js
Outdated
| it("should run the eslint:rule generator", function() { | ||
| assert.ok(this.spy.calledOnce); | ||
| it("does not blow up", () => { | ||
| assert.ok(true); |
There was a problem hiding this comment.
It looks like this test isn’t doing anything. Maybe a placeholder you meant to update?
There was a problem hiding this comment.
Added real test for this.
Significantly modernizes code and tests. Significantly improves test coverage.
With the latest yeoman dependencies, I was seeing errors under Node 12/14, unless NPM 7 was used to install dependencies: - Uncaught Error: Cannot find module 'rimraf' - Uncaught Error: Cannot find module 'mkdirp'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly modernizes code and tests.
Significantly improves test coverage.
TODO:
-
Uncaught Error: Cannot find module 'rimraf'-
Uncaught Error: Cannot find module 'mkdirp'- Recreating package-lock.json helped, but I was still seeing errors on Node 12/14 until I switched CI to use NPM v7 when installing dependencies. This is the same thing the yeoman-environment does on its CI configuration.
Fixes #43.
Fixes #86.
CC: @platinumazure