Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: drop Node 12/17 support #135

Merged
merged 1 commit into from Jul 15, 2022
Merged

feat!: drop Node 12/17 support #135

merged 1 commit into from Jul 15, 2022

Conversation

bmish
Copy link
Sponsor Member

@bmish bmish commented Jul 13, 2022

Goal is to match upcoming ESLint v9 core Node version support:

https://github.com/eslint/eslint/blob/845c4f40274ccb3727c624db44c7a23aafa71318/package.json#L164

@eslint-github-bot
Copy link

Hi @bmish!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?

To Fix: You can fix this problem by running git commit --amend, editing your commit message, and then running git push -f to update this pull request.

Read more about contributing to ESLint here

@bmish bmish changed the title breaking: drop Node 12/17 support feat!: drop Node 12/17 support Jul 13, 2022
@nzakas
Copy link
Member

nzakas commented Jul 14, 2022

Can you combine this with #133 ?

@bmish
Copy link
Sponsor Member Author

bmish commented Jul 14, 2022

Just to explain my motivation here, I submitted these as two changes:

  1. Drop Node versions
  2. Upgrade dependencies

Because:

  • Dropping Node versions is considered a breaking change while upgrading dependencies afterward is just a non-breaking feature/enhancement. I consider it good practice to isolate breaking changes from subsequent changes enabled by the breaking changes (of which there could be many).
  • Both of these changes are relevant to consumers and deserve to be mentioned in the changelog, and I think it's nice to give each their own bullet point (by way of a separate PR) instead of trying to cram multiple into one.

@bmish
Copy link
Sponsor Member Author

bmish commented Jul 14, 2022

@nzakas if we're considering generator-eslint package.json changes breaking but not the plugin template package.json, then I can split this into two PRs (one for each package.json), so we can release non-breaking changes first.

@nzakas
Copy link
Member

nzakas commented Jul 14, 2022

I don't think there's much benefit to releasing non-breaking changes first. This package gets under 500 downloads a week, and people use it once and forget it, so we're not at much risk of breaking people's experiences. I'd say let's just merge everything and release it.

@bmish
Copy link
Sponsor Member Author

bmish commented Jul 14, 2022

Fair enough. Then I think we can merge everything and do a major release.

@nzakas nzakas merged commit 9675983 into main Jul 15, 2022
@nzakas nzakas deleted the drop-node-12 branch July 15, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants