New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: drop Node 12/17 support #135
Conversation
Hi @bmish!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by running Read more about contributing to ESLint here |
Can you combine this with #133 ? |
Just to explain my motivation here, I submitted these as two changes:
Because:
|
@nzakas if we're considering generator-eslint package.json changes breaking but not the plugin template package.json, then I can split this into two PRs (one for each package.json), so we can release non-breaking changes first. |
I don't think there's much benefit to releasing non-breaking changes first. This package gets under 500 downloads a week, and people use it once and forget it, so we're not at much risk of breaking people's experiences. I'd say let's just merge everything and release it. |
Fair enough. Then I think we can merge everything and do a major release. |
Goal is to match upcoming ESLint v9 core Node version support:
https://github.com/eslint/eslint/blob/845c4f40274ccb3727c624db44c7a23aafa71318/package.json#L164