Build: Pinning run-async dependency to 2.2.x #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
run-asyncpackage released version 2.3.0 recently, which completely dropped support for Node 0.10 by removing a Promise polyfill they were using internally. This has broken our master build.We should drop Node 0.10 support at some point, but I'd rather do that as a semver-major change. For now, this PR just adds a run-async dependency (pinning at 2.2.x) so that
npm installwill install the right version on Travis and keep this package working in Node 0.10 for now.If we merge this, we can cut a minor release (when we're done with any other features we may want to add), and then drop Node 0.10 and Node 5 support in a semver-major release.