Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Add eslint-plugin-eslint-plugin to plugin generator #79

Merged
merged 1 commit into from Jul 2, 2021

Conversation

bmish
Copy link
Sponsor Member

@bmish bmish commented Jun 29, 2021

Partially fixes #65.

We want to encourage the adoption of eslint-plugin-eslint-plugin to help ESLint plugin authors follow best practices including avoiding using deprecated APIs and producing rules with good usability.

I'll follow-up after this to add eslint-plugin-node and make some other improvements too.

@eslint-github-bot
Copy link

Hi @bmish!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

  • The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

@bmish bmish force-pushed the eslint-plugin-eslint-plugin branch 2 times, most recently from de886f6 to 5c47435 Compare June 29, 2021 00:23
@nzakas
Copy link
Member

nzakas commented Jul 2, 2021

Please check the file conflicts.

@bmish bmish force-pushed the eslint-plugin-eslint-plugin branch from 5c47435 to d865373 Compare July 2, 2021 04:00
@bmish
Copy link
Sponsor Member Author

bmish commented Jul 2, 2021

Fixed conflicts. I'll open up several more PRs after this.

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

We want to encourage the adoption of [eslint-plugin-eslint-plugin](https://www.npmjs.com/package/eslint-plugin-eslint-plugin) to help ESLint plugin authors follow best practices including avoiding using deprecated APIs and producing rules with good usability.
@bmish bmish force-pushed the eslint-plugin-eslint-plugin branch from d865373 to 18ee0f5 Compare July 2, 2021 14:17
@bmish bmish changed the title Add eslint-plugin-eslint-plugin to plugin generator UpdatAdd eslint-plugin-eslint-plugin to plugin generator Jul 2, 2021
@bmish bmish changed the title UpdatAdd eslint-plugin-eslint-plugin to plugin generator New: Add eslint-plugin-eslint-plugin to plugin generator Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider add eslint-plugin-eslint-plugin and eslint-plugin-node
3 participants