Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update and autofix internal linting #88

Merged
merged 1 commit into from Jul 2, 2021

Conversation

bmish
Copy link
Sponsor Member

@bmish bmish commented Jul 2, 2021

Also switches to a flat/consolidated .eslintrc.js file.

Part of #86.

Also switches to a flat/consolidated .eslintrc.js file.
@@ -8,7 +8,7 @@
* Regex for valid IDs
* @type {RegExp}
*/
var rValidId = /^(?:[a-z0-9]+(?:-[a-z0-9]+)*)$/;
const rValidId = /^(?:[a-z0-9]+(?:-[a-z0-9]+)*)$/u;
Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only violation that was not autofixed (I fixed manually).

https://eslint.org/docs/rules/require-unicode-regexp

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@nzakas nzakas merged commit 6d0cc94 into eslint:main Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants