-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add 2023-06-29 meeting notes #439
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
# 2023-06-29 ESLint TSC Meeting Notes | ||
|
||
## Transcript | ||
|
||
[`2023-06-29-transcript.md`](2023-06-29-transcript.md) | ||
|
||
## Attending | ||
|
||
* Nicholas C. Zakas (@nzakas) - TSC | ||
* Milos Djermanovic (@mdjermanovic) - TSC | ||
|
||
@nzakas moderated, and @sam3k took notes. | ||
|
||
## Topics | ||
|
||
### [Where we are on the integration with outside plugins/configs listed on this issue?](https://github.com/eslint/eslint/issues/13481) | ||
|
||
> @nzakas: On my end, I've opened PRs for each of the projects. None have been merged yet. | ||
|
||
Status: | ||
- [x] `eslint-plugin-n` now provides flat config exports | ||
- [ ] `typescript-eslint` PR opened; waiting for Nx to get updated to use flat config | ||
- [ ] `eslint-config-standard` PR opened | ||
- [ ] `eslint-plugin-vue` PR opened | ||
- [ ] `eslint-plugin-react` PR to be submitted by @mdjermanovic | ||
- [ ] `eslint-plugin-import` Issue has been [opened](https://github.com/import-js/eslint-plugin-import/issues/2556) and accepted. PR to be submitted by @mdjermanovic | ||
- [ ] `eslint-config-airbnb` @mdjermanovic will start a discussion in [this](https://github.com/airbnb/javascript/issues/2699) issue to figure out whether we should switch the main export to a flat config or provide an additional export to the flat config. | ||
- [x] `eslint-config-eslint` ESLint config to load external configs/plugins without FlatCompat is done | ||
|
||
> @nzakas think the only thing we can start doing in phase 4 is the blog post to encourage people to start switching over and explain the rollout plan. At a higher level, I'd like to get phase 2 of the language plugins tasks completed before we release ESLint v9 (with flat config as the default). I'm hopeful I'll be able to do that in July. | ||
|
||
**Action Items:** | ||
* @mdjermanovic will create pull requests for `eslint-plugin-react` and `eslint-plugin-import` | ||
* @mdjermanovic will start a discussion with the AirBnB team on `eslint-config-airbnb` options | ||
|
||
|
||
### Let's discuss where we are with the release-please rollout | ||
|
||
Are all repos aside from eslint/eslint now switched over? This is the status: | ||
|
||
- [x] `eslintrc` | ||
- [x] `espree` | ||
- [x] `create-config` | ||
- [x] `eslint-visitor-keys` | ||
- [x] `generator-eslint` | ||
- [x] `eslint-scope` | ||
- [x] `eslint-transforms` | ||
- [x] `eslint-plugin-markdown` | ||
|
||
**Action Items:** The Jenkins jobs have not been deleted and @mdjermanovic will move them into the `Obsolete Jobs` folder as a backup. | ||
|
||
|
||
### Scheduled release for June 30th, 2023 | ||
|
||
**Action Items:** @mdjermanovic will release the following: | ||
* `espree` with the new syntax support (regex v flag) so that it will be easier to work on rules | ||
* `@eslint/eslintrc` | ||
* `@eslint/js` | ||
* `eslint` | ||
* `eslint-config-eslint` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint-plugin-react has added its support in v7.32.0:
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md#added-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint-plugin-react started exporting flat configs in v7.32.0 but they are not using flat config in the repo. That's what @mdjermanovic is going to send a PR for