Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Make eslint a peer dependency #523

Closed
patsissons opened this issue Oct 2, 2018 · 2 comments
Closed

Make eslint a peer dependency #523

patsissons opened this issue Oct 2, 2018 · 2 comments
Assignees

Comments

@patsissons
Copy link

typescript-eslint-parser is now pulling in eslint@4.19.1, ideally it should be asking for a peer dependency of "eslint": ">=4.19.1". This would allow de-duplication of the eslint dependency in consumers of typescript-eslint-parser using a different version of eslint.

A current workaround is to pin the eslint dependency in a consuming project using a resolution. For example, to force using eslint@^5.0.0

"resolutions": {
  "eslint": "^5.0.0",
}
@milesj
Copy link

milesj commented Oct 9, 2018

+1

@platinumazure
Copy link
Member

platinumazure commented Oct 9, 2018

Hi @patsissons, thanks for the issue!

I agree that ESLint should probably not be a dependency anymore in this project. I'll try to take a look at fixing this week.

@platinumazure platinumazure self-assigned this Oct 13, 2018
platinumazure added a commit that referenced this issue Oct 31, 2018
…" (#537)

* Revert "20.1.0"

This reverts commit de1f514.

* Revert "Build: changelog update for 20.1.0"

This reverts commit edbe70e.

* Revert "Chore: Make ESLint a devDependency/peerDependency (fixes #523) (#526)"

This reverts commit 075d243.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants