Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Fix: visiting implements in classes #562

Merged
merged 2 commits into from Nov 28, 2018
Merged

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 22, 2018

This PR adds visiting of implements to classes

@armano2 armano2 mentioned this pull request Nov 22, 2018
14 tasks
@armano2 armano2 changed the title Fix: missing implements in classes Fix: visiting implements in classes Nov 22, 2018
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion, otherwise LGTM.

analyze-scope.js Show resolved Hide resolved
@armano2
Copy link
Contributor Author

armano2 commented Nov 28, 2018

ok, now i have to just resolve conflicts here :>

@platinumazure platinumazure merged commit 8ff0ad1 into eslint:master Nov 28, 2018
@platinumazure
Copy link
Member

@armano2 Merged, thanks for contributing!

@armano2 armano2 deleted the patch-5 branch November 28, 2018 22:13
@armano2
Copy link
Contributor Author

armano2 commented Nov 28, 2018

@platinumazure thank you for unblocking migration of eslint-plugin-typescript to latest version

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants