Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping. Remove File processing code from Webform Handler #84

Closed
DiegoPino opened this issue Dec 17, 2020 · 1 comment
Closed

Housekeeping. Remove File processing code from Webform Handler #84

DiegoPino opened this issue Dec 17, 2020 · 1 comment
Assignees
@DiegoPino
Labels
enhancement New feature or request UI/UX The thing people do when in front of a screen Webform Handler Webform Widgets Connecting Webforms and Entity Fields

Comments

@DiegoPino
Copy link
Member

What legacy code in such a novel project?

We have. Initially most of the processing logic was in the webform handler. We moved in Beta2 and beta3 a lot into EventSubscribers. But we left for fear (because we care about your files) some code that did the same in the webform handler.

We can now get rid of that code and make processing faster. The associated pull will also include some other tiny housekeeping changes, mostly cosmetic and related to performance.

Thanks
@DiegoPino DiegoPino self-assigned this Dec 17, 2020
@DiegoPino DiegoPino added enhancement New feature or request Webform Handler Webform Widgets Connecting Webforms and Entity Fields UI/UX The thing people do when in front of a screen labels Dec 17, 2020
@DiegoPino DiegoPino mentioned this issue Jan 5, 2021
Merged
@DiegoPino
Copy link
Member Author

Resolve via f9a3487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiegoPino DiegoPino

Labels
enhancement New feature or request UI/UX The thing people do when in front of a screen Webform Handler Webform Widgets Connecting Webforms and Entity Fields
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DiegoPino