Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-85 and ISSUE-84: Allow multivalued Webform elements to read single valued JSON data #86

Merged
merged 3 commits into from
Jan 6, 2021

Conversation

DiegoPino
Copy link
Member

See #85 and #84

The last one is just clean up of old code we no (hopefully!) need anymore since Event Subscribers are in charge of persisting and classifying. Makes webform operations faster. But I need to test this before merging.

@DiegoPino DiegoPino self-assigned this Jan 5, 2021
@DiegoPino DiegoPino added bug Something isn't working Drupal 9 After Drupal 8, Before Drupal 10 enhancement New feature or request Webform Elements Things with input to fill and interact with while ingesting metadata Webform Widgets Connecting Webforms and Entity Fields labels Jan 5, 2021
@DiegoPino DiegoPino added this to the 1.0.0 milestone Jan 5, 2021
@DiegoPino
Copy link
Member Author

@alliomeria I will merge as it is and will do the Help element thing for Nominatim in another pull

@DiegoPino DiegoPino merged commit f9a3487 into 1.0.0-RC1 Jan 6, 2021
@DiegoPino DiegoPino deleted the ISSUE-85 branch January 6, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Drupal 9 After Drupal 8, Before Drupal 10 enhancement New feature or request Webform Elements Things with input to fill and interact with while ingesting metadata Webform Widgets Connecting Webforms and Entity Fields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant