Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/45 version 1 #56

Merged
merged 11 commits into from
Jan 17, 2024
Merged

Feature/45 version 1 #56

merged 11 commits into from
Jan 17, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Jan 14, 2024

Description

  • Add espp::Max1704x component for battery monitoring
  • Refactored main code a little to make it simpler and easier to understand
  • Adjusted stack sizes to free up unused space (based on task monitor output)
  • Refactor box-emu-hal component to make it easier to use (include) and easier to see what the interface is (esp. now that everything but the lvgl interface supports c++)

Motivation and Context

Closes #45 by providing an implementation of the remaining new features for Version 1 of the hardware.

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Task monitor output after running on Hardware V1 and running all the emulators and loading saves:
CleanShot 2024-01-16 at 15 11 21@2x

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

Copy link

github-actions bot commented Jan 14, 2024

✅Static analysis result - no issues found! ✅

@finger563 finger563 added audio battery hal hardware abstraction layer labels Jan 17, 2024
@finger563 finger563 merged commit f68603e into main Jan 17, 2024
2 checks passed
@finger563 finger563 deleted the feature/45-version-1 branch January 17, 2024 03:02
@finger563 finger563 restored the feature/45-version-1 branch January 17, 2024 03:02
@finger563 finger563 deleted the feature/45-version-1 branch January 17, 2024 03:02
finger563 added a commit that referenced this pull request Jan 18, 2024
* Fix mute button event handler in menu and gui for error introduced in #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio battery hal hardware abstraction layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firmware support for Version 1
1 participant