-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/45 version 1 #56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved various parts of the code around for simplicity
✅Static analysis result - no issues found! ✅ |
* Updated gui / menu to support volume change events * Updated hal to generate volume change events on v1 * Updated stack sizes to waste less memory * Updated espp submodule to support lowering display stack size
finger563
added a commit
that referenced
this pull request
Jan 18, 2024
* Fix mute button event handler in menu and gui for error introduced in #56
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
espp::Max1704x
component for battery monitoringbox-emu-hal
component to make it easier to use (include) and easier to see what the interface is (esp. now that everything but the lvgl interface supports c++)Motivation and Context
Closes #45 by providing an implementation of the remaining new features for Version 1 of the hardware.
How has this been tested?
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Task monitor output after running on Hardware V1 and running all the emulators and loading saves:
![CleanShot 2024-01-16 at 15 11 21@2x](https://private-user-images.githubusercontent.com/213467/297190340-7c950b58-2b5f-4fee-9fd4-20f467b40b96.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM1NzA5MDQsIm5iZiI6MTcyMzU3MDYwNCwicGF0aCI6Ii8yMTM0NjcvMjk3MTkwMzQwLTdjOTUwYjU4LTJiNWYtNGZlZS05ZmQ0LTIwZjQ2N2I0MGI5Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgxM1QxNzM2NDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mOTE3MTBiMDEyMWYwMjlmZTRjODg3ODA4ZDdkYTU3OTY3YjE4ZDdmN2Q3MjA4YjYwNjIwMDMzNThjOWRiMWM3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.7qojgs9mPlHXPnuWThjJdpwWwTstkXUdwQUjzqyENKg)
Types of changes
Checklist:
Software
.github/workflows/build.yml
file to add my new test to the automated cloud build github action.