Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hal): update hal to work across v0 and v1 #57

Merged
merged 6 commits into from
Jan 18, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented Jan 18, 2024

Description

  • Update HAL component to probe the bus and figure out whether the hardware plugged in is EMU V0 or EMU V1
  • Updated espp submodule to have unified interfaces between gt911 and tt21100
  • Fix task stack size for gui to handle case when usb is enabled (bug introduced in Feature/45 version 1 #56)
  • Fix mute button handler bug introduced in Feature/45 version 1 #56
  • Added more boxart for sms and gg roms :)

Motivation and Context

The ESP32-S3-BOX can plug into EMU hardware V0 and V1 (both of which I have). It would be nice to not have to reflash the box just to switch hardwares since they're more or less functionally equivalent and the i2c bus probing can determine what features to enable and which to disable.

How has this been tested?

  • Building and running on ESP32-S3-BOX and plugging into EMU V0 and EMU V1 without reprogramming.
  • Building and running on ESP32-S3-BOX-3 to validate that it still compiles for it and the touch driver still works.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

box-emu-hal-support-compressed.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Update HAL component to probe the bus and figure out whether the hardware plugged in is EMU V0 or EMU V1
* Updated espp submodule to have unified interfaces between gt911 and tt21100
Copy link

github-actions bot commented Jan 18, 2024

✅Static analysis result - no issues found! ✅

@finger563 finger563 self-assigned this Jan 18, 2024
@finger563 finger563 added enhancement New feature or request hal hardware abstraction layer labels Jan 18, 2024
@finger563 finger563 changed the title feat(compat): update hal to work across v0 and v1 feat(hal): update hal to work across v0 and v1 Jan 18, 2024
@finger563 finger563 merged commit 86d523f into main Jan 18, 2024
2 checks passed
@finger563 finger563 deleted the feature/cross-compatibility branch January 18, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hal hardware abstraction layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant