Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(genesis): disable sound emulation when muted for better performance #65

Merged
merged 1 commit into from
May 19, 2024

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented May 19, 2024

Description

Motivation and Context

Since genesis emulation is currently slow, disable sound emulation when sound output is muted for more playable framerates.

How has this been tested?

Building and running on Box-3 and playing sonic. See #60 video for reference.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 added enhancement New feature or request genesis labels May 19, 2024
Copy link

✅Static analysis result - no issues found! ✅

@finger563 finger563 merged commit 7eae0d5 into main May 19, 2024
2 checks passed
@finger563 finger563 deleted the feature/genesis-sound-disable-muted branch May 19, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request genesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant