Add direct-boot support for ESP32-S3#107
Merged
Merged
Conversation
MabezDev
reviewed
Jul 19, 2022
Member
|
Sorry if this is a silly question, but what am I missing here? |
Contributor
Author
Are you using the espflash with today's changes? |
Member
|
Ahh I knew I was forgetting something haha, thanks. Flashes now but I get a backtrace: (This repeats) |
Contributor
Author
|
Hmmm ... Maybe a wrong alignment? Will check that tomorrow - thanks a lot for testing Could you try some other examples and maybe release vs debug builds? |
Member
|
The |
Contributor
Author
|
That's very useful - thanks a lot! |
Contributor
Author
|
@jessebraham Should now work in both - release and development mode |
MabezDev
reviewed
Jul 20, 2022
MabezDev
reviewed
Jul 20, 2022
…t feature is selected
jessebraham
approved these changes
Jul 20, 2022
jessebraham
left a comment
Member
There was a problem hiding this comment.
Working for both profiles now, thanks!
jrmoulton
pushed a commit
to jrmoulton/esp-hal
that referenced
this pull request
Jul 30, 2022
* Add direct-boot support for ESP32-S3 * Make sure to use correct alignments * Only enable naked_functions and asm_experimental_arch when direct-boot feature is selected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this we can make use of the direct-boot feature of ESP32-S3.
Please note: We need a recent
espflashexecutable to actually flash the binaryFixes #39