Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3/3] Timer abstraction: cleanup, simplification, and documentation #1630

Merged
merged 7 commits into from
May 28, 2024

Conversation

jessebraham
Copy link
Member

This should wrap up my work on the timer abstraction layer. This PR still needs testing, as I have changed some APIs a bit and as such they need confirmation. However, I think everything should be in okay shape.

The documentation definitely could use some improving, but I was struggling to come up with what more I could write or some better examples. Open to any input here, but perhaps that can be improved in another PR by somebody else instead.

I don't think this really needs a CHANGELOG.md entry, but let me know if I've missed anything; happy to add one if needed.

Closes #1479.

@jessebraham jessebraham added the skip-changelog No changelog modification needed label May 27, 2024
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing this up! I really liked how this turned out, hopefully it will make some future abstractions in esp-wifi etc a bit easier.

I still need to do some testing tomorrow, but I noticed one thing regarding the load_value checks for systimer.

esp-hal/src/timer/systimer.rs Outdated Show resolved Hide resolved
@jessebraham
Copy link
Member Author

Really questioning the value of clippy these days... 😓

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Code looks good to me and I did some tests on a previous commit - wouldn't expect anything bad from the latest commits. Looking forward to use the timer abstraction in esp-wifi later

@jessebraham jessebraham added this pull request to the merge queue May 28, 2024
Merged via the queue into esp-rs:main with commit 8aee84f May 28, 2024
21 checks passed
@jessebraham jessebraham deleted the feature/timer-abstraction-2 branch May 28, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Timer abstraction design
3 participants